Repository navigation
feat: query_memory_limit and QRY-012 (minigraf#549) - #12
Merged
Merged
Conversation
Add query_memory_limit to OpenOptions and minigraf.open(): the most bytes one query may hold, a query that would hold more raising QRY-012. i64::MAX stands for core's usize::MAX (no limit, the default), as for wal_checkpoint_threshold. Bump the core v3 pin to df7282f1. Core now deprecates max_results as an alias of max_derived_facts; the option stays, documented as the alias. Core's uuid no longer enables v4 for this target, so the tests use a fixed UUID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding side of project-minigraf/minigraf#549 on v3.
OpenOptions.query_memory_limitandminigraf.open(query_memory_limit=...): the most bytes one query may hold. A query that would hold more raisesMiniGrafError.Querywith[QRY-012].2**63 - 1(i64::MAX) maps to core'susize::MAX, no limit, the default — aswal_checkpoint_thresholddoes.max_resultsas an alias ofmax_derived_facts(#553); the option stays, documented as the alias. Core'suuidno longer enablesv4here, so two unit tests use a fixed UUID.executeand from a cursor, i64::MAX → no limit, -1 → API-017) and a pytest case. README documents the option.The consumer-test job installs the built wheel and runs the README quick start and contract.
🤖 Generated with Claude Code
https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT