Repository navigation
fix: lesson starter code that gave wrong answers or errors - #46
Merged
Merged
Conversation
- basic-datalog l1-s1/l1-s2: Alice's two :friend facts were written in one transact, which Minigraf v2.x reads back as one value (known issue project-minigraf/minigraf#371), so l1-s2 returned no rows instead of :bob. They go in separate transacts, as l1-s3 already does. - org-chart: Eve's salary correction {:valid-to "2025-03-31"} had no :valid-from, so its window started at the transaction time: empty on v2.x, rejected with API-019 by v3.0.0. It now runs from her hire date (2023-03-01) to 2025-04-01, the day the raise applies. - sports-league sl3-s4: (transfer-chain ?club :rovers) fails with INT-022 on every Minigraf release (project-minigraf/minigraf#608). The step binds the destination with a predicate instead until that is fixed. - system prompt: per-fact pseudo-attributes without :any-valid-time fail with INT-026; they do not fall back to currently valid facts. Tests guard the first two classes for every lesson. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by an audit that ran every lesson step on Minigraf v2.x (
main28f4a4eb) andv3(e078e46b) and compared the answers withexpectedResult.l1-s1,l1-s2:friendfacts in onetransact: v2.x reads them back as one value (project-minigraf/minigraf#371), sol1-s2returned[]instead of:bobtoday on 2.0.6l1-s3already doeso2-s1–o2-s4,o3-s4{:valid-to "2025-03-31"}without:valid-fromstarts at the transaction time: an empty window on v2.x; rejected with API-019 by v3.0.0, which would make the whole step error{:valid-from "2023-03-01" :valid-to "2025-04-01"}(hire date to the raise)sl3-s4(transfer-chain ?club :rovers)fails with INT-022 on every release (project-minigraf/minigraf#608)(transfer-chain ?club ?dest) [(= ?dest :rovers)]until #608 is fixed; hint updated:any-valid-timesee only currently valid facts; they fail with INT-026New tests in
__tests__/lib/lessons.test.tscheck every lesson for the first two classes (one entity/attribute twice in atransact; a:valid-tomap without:valid-from), plus a prompt test for INT-026. Each failed before the fix.npm test: 232 passed.After the change, every step runs without error on both v2.x and v3, and each step with an
expectedResultmatches it on both.v3-only prompt changes (pseudo-attribute source rule / PRS-081, unknown aggregates as QRY-010/QRY-011) wait for the playground's upgrade to
@minigraf/browser3.x.🤖 Generated with Claude Code
https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR