Repository navigation
feat: set values (#316) - #14
Merged
Merged
Conversation
Shim synced with the binding template: MiniGrafValue.set both ways, a nested set is API-021, execute() returns a set as an array. A Swift Set of MinigrafSetElement binds a set value (UUID elements are refs). Pin core v3 at 7c8c5540. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 24 of the minigraf#316 plan (PR 4), Swift.
MiniGrafValue.setboth ways, a nested set is API-021,execute()JSON returns a set as an array, wildcard arms for core's#[non_exhaustive]Value.MinigrafSetElementprotocol (Bool, Int/Int32/Int64, Double/Float, String,UUIDas a ref,MiniGrafValue) andSet: MinigrafBindable where Element: MinigrafSetElement. A computed property can't throw, so non-value elements are rejected at compile time; mixed types useSet<MiniGrafValue>.Tests/swift/main.swift): Swift/empty/typed sets, equality with a stored set, JSON array, fact record, UUID element, API-021. Consumer contract: a set comes back and binds.No local Swift toolchain, so the first compile happens in CI. 35 cargo tests pass locally.
Depends on minigraf-binding-template#8 (same shim).
🤖 Generated with Claude Code
https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF