Repository navigation
feat: set values (#316) - #19
Merged
Merged
Conversation
A set binds as { type: 'set', value: [...] } or a JS Set (minigraf.js turns
a Set into the typed form, in elements too); elements are plain or typed
value forms, another form is API-017, a nested set API-021. FactValue gains
'set' for fact records and the log writer; execute() returns a set as an
array. Pin core v3 at 7c8c5540.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 25 of the minigraf#316 plan (PR 4), Node.js.
bind_valuereads{ type: 'set', value: [...] }. Elements are plain values or typed value forms; an element in another form (entity, txCount, timestamp, anyValidTime) is API-017, a set inside a set is API-021 (ValueSet::new), and a non-arrayvalueis API-017. An unrecognised element or a plain array is aTypeError. This matchesBrowserDb(minigraf#753).minigraf.jswrapsPreparedQuery.execute/queryso a JSSet, including one inside a typed set, becomes the typed form. (napi has no cleaninstanceof Setcheck from Rust.)FactValuegains'set'(valuean array ofFactValue) for fact records andLogWriter;value_to_jsonreturns arrays; wildcard arms for core's#[non_exhaustive]Value.index.d.tsregenerated.25 tests pass locally (laptop: no Node on the bench machine).
🤖 Generated with Claude Code
https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF