Repository navigation
fix(readme): document the uniffi.minigraf_ffi package 2.x ships; consumer-test v2.x - #11
Merged
Merged
Conversation
…umer-test v2.x Every 2.x jar has its classes in uniffi.minigraf_ffi; the README quick start imported io.github.project_minigraf.minigraf.MiniGrafDb, which only exists from v3.0.0 (the package rename is a breaking change, so it stays out of 2.x). The install snippets said 1.2.0 and 1.1.1. 2.0.x patch releases run main's workflows on this branch, so this branch gets what they need: the reproducible-archive settings and the build/m2 dist repository in build.gradle.kts, and consumer-test/ written against the 2.x API (MiniGrafDb.Companion from Java). The workflow files are copies of main's, so PRs to v2.x run the same package and consumer tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
The 2.x NativeLoader picked the glibc native on musl and the x86_64 DLL on Windows arm64, so the jar, which ships both natives, failed to load on Alpine and Windows arm64 (UnsatisfiedLinkError). Backports main's loader (java#5), which resolves by libc and architecture and caches the extracted native, with its tests (less the Java facade test; 2.x has no facade), and the matching copyLocalNative mapping. Found by the new consumer test's Alpine and windows-11-arm legs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan step 3 (
v2.x) of the core binding consumer-test spec. This must merge before themainPR, because themainPR's CI packages and consumer-testsv2.x.Fixed
README import: every 2.x jar has its classes in
uniffi.minigraf_ffi. The README quick start importedio.github.project_minigraf.minigraf.MiniGrafDb, which doesn't compile against any released jar. That rename is onmainand ships in v3.0.0; it stays out of 2.x because it breaks callers (decided 2026-10-20).Versions and output: the install snippets said 1.2.0 and 1.1.1, and the README showed
{"transacted":1}, which isn't the real output.Alpine and Windows arm64 (2.x jar fails to load on Alpine (musl) and Windows arm64 #13): the 2.x
NativeLoaderpicked the glibc native on musl and the x86_64 DLL on Windows arm64, so the jar failed to load on Alpine and Windows arm64, even though it ships those natives. This backportsmain's loader (java#5) and its tests, minus the facade test. The consumer test's Alpine andwindows-11-armlegs found it. Ships in v2.0.9.Added (what 2.0.x releases need, since they run
main's workflows on this branch)build.gradle.kts: reproducible archives and thebuild/m2dist repository.consumer-test/: written against the 2.x API, withMiniGrafDb.Companion.open(...)from Java.ci.yml,package.ymlandverify-published.ymlare copies ofmain's from themainPR, so PRs tov2.xrun the same package and consumer tests.Verified locally: all 4 consumer tests pass against a jar built from this branch.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz