Repository navigation
fix: usable archives on every platform; consumer-test every build - #5
Merged
Merged
Conversation
…st every build The Windows zip had no minigraf.dll.lib, so MSVC could not link against it; no archive shipped the license files; the header sat at the root of the Windows zip but under include/ elsewhere; Linux libraries needed the build runner's glibc (2.34). - package.yml builds the four release archives with one layout (library, minigraf.dll.lib on Windows, include/minigraf.h, licenses); Linux via cargo-zigbuild at glibc 2.17 with a floor check; macOS checks both universal2 slices. - consumer-test/: run.sh unpacks this platform's archive, compiles the README quick start and contract.c (in memory, file-backed reopen, NULL plus minigraf_last_error for invalid Datalog) with cc, or cl and the import library on Windows, and runs them; local|registry. readme_sync.py checks the README quick start against quickstart.c. - ci.yml: package, consumer test on the four platforms, readme-sync. - release.yml: the test job builds and consumer-tests the archives at the release version; publish uploads exactly those files; verify-published downloads them from the release and opens a release-broken issue on failure. - README: archive contents, glibc floor, the MSVC compile line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
rustc recorded the build directory as LC_ID_DYLIB, so every program linked against the released dylib looked for it on the CI runner and failed to start. Found by the macOS consumer test; 2.0.8 is affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
adityamukho
marked this pull request as ready for review
October 20, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan step 2 of the core binding consumer-test spec (
docs/superpowers/specs/2026-10-20-binding-consumer-tests-design.md).Fixed: four bugs in the published archives (2.0.8 and earlier)
/Users/runner/work/.../deps/libminigraf.dylib), so any program linked against it failed to start withdyld: Library not loaded. The new macOS consumer test found this. It's now@rpath/libminigraf.dylib, and the build checks it.minigraf.dll.lib, so MSVC could not link. The header was also at the zip root instead of underinclude/.cargo zigbuildat glibc 2.17, with a floor check, as Java does.Added
package.yml: builds the 4 archives with one layout: the library,minigraf.dll.libon Windows,include/minigraf.h, and the licenses. It checks both universal2 slices.consumer-test/:run.sh local|registryunpacks this platform's archive and compiles the README quick start andcontract.cexactly as a user would: the README'sccline, orclwith the import library on Windows. Then it runs them.contract.ccovers:minigraf_last_error.readme_sync.pychecks the README quick start againstquickstart.c.ci.yml:package, a consumer test on all 4 platforms, andreadme-sync.release.yml:testjob builds and consumer-tests the archives at the release version.publishuploads exactly those 4 files.verify-publisheddownloads them from the release, runs the consumer test on all 4 platforms, and opens arelease-brokenissue if it fails.README: archive contents, the glibc floor, and the MSVC compile line.
Verified
CI is green:
@rpath/libminigraf.dylib;archs: x86_64 arm64.Locally,
run.sh registry 2.0.8fails witharchive has no LICENSE-MIT. After merge I'll dispatchverify-published -f version=2.0.8. It should open arelease-brokenissue for the four bugs above.Codex review found no issues.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz