8000 Require linkcheck to pass in CI by stevepiercy · Pull Request #1020 · plone/training · GitHub
[go: up one dir, main page]

Skip to content

Require linkcheck to pass in CI - #1020

Merged
stevepiercy merged 8 commits into
mainfrom
require-linkcheck
Sep 21, 2026
Merged

stevepiercy merged 8 commits into
mainfrom
require-linkcheck

Conversation

@stevepiercy
Copy link
Copy Markdown
Member

Closes #1018

@stevepiercy
Copy link
Copy Markdown
Member Author

Cool, that failed, which is what I expected. However, let's see if we can get a cleaner result with linkcheckbroken.

@stevepiercy
Copy link
Copy Markdown
Member Author

I don't know how to get the CI failure to provide a nice error report such as that provided by make linkcheckbroken locally. CI and local have different outputs. So I resorted to make linkcheck -W. This will fail on both broken links and redirects, although its output is verbose.

Trainers can run make linkcheckbroken to get a nice summary without all the noise from OKs and sleeps.

@stevepiercy
stevepiercy merged commit 65e51da into main Sep 21, 2026
2 of 3 checks passed
8000
@stevepiercy
stevepiercy deleted the require-linkcheck branch September 21, 2026 23:09
@github-project-automation github-project-automation Bot moved this from New to Done in Plone Documentation Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make linkcheckbroken required to pass for PR merge

1 participant

0