Repository navigation
Add Prometheus exporter as a separate module (x/prometheus) - #5
Merged
Merged
Conversation
Observability phase 3b: x/prometheus is its own module (own go.mod) implementing flow.Meter on prometheus/client_golang, so the core stays zero-dependency — only importers of the exporter pull client_golang in. NewMeter(reg) maps flow's instruments to flow_<name>_total counters and a flow_process_latency_seconds histogram; instruments are memoized so a Meter can be reused across runs without duplicate registration. Pinned to client_golang v1.20.5 to keep the module on Go 1.23. CI now also vets and race-tests x/*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observability phase 3b — the first metrics exporter, as a separate module.
What
x/prometheusis its own module (github.com/pabloos/flow/x/prometheus, owngo.mod) implementingflow.Meteronprometheus/client_golang:flow_<name>_total;process_latency→flow_process_latency_seconds.Metercan be reused across runs without duplicate registration (tested).Why a separate module
The core
flowmodule stays zero-dependency — only code that importsx/prometheuspulls inclient_golang. This is the boundary we agreed: contract in core, dependency-carrying exporters outside.Notes
client_golang v1.20.5to keep the module on Go 1.23 (latest pulls in a Go 1.25 requirement).v0.5.0(the release that addedMeter).x/*submodules.x/prometheus/v0.1.0after merge (Go's path-prefixed submodule tag convention).