Repository navigation
Bump exporters to flow v0.8.0 for the Metrics rename - #12
Merged
Merged
Conversation
v0.8.0 renamed the WithMeter option to Metrics. The exporters only used it from their tests, so this is the rename plus the dependency bump; neither NewMeter signature changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.8.0settled the remaining pre-v1.0 API warts, one of which renamed theWithMeteroption toMetrics. The exporters referenced it only from their tests, so this is that rename plus the dependency bump.x/prometheus,x/otel—flow v0.7.0→v0.8.0flow.WithMeter(...)→flow.Metrics(...)Neither
NewMetersignature changes, and no exporter behaviour changes.Verification
go vet+go test -race -count=1green in both submodules against the real taggedflow v0.8.0, with nogo.work. NoWithMeterreference remains anywhere in the repo.Suggests
x/prometheus/v0.4.0andx/otel/v0.4.0once merged.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGsdwoFd3a7bejBXLr6saG