8000 feat: Add missing password policy entries by hypery2k · Pull Request #1071 · keycloakify/keycloakify · GitHub
[go: up one dir, main page]
Skip to content

feat: Add missing password policy entries - #1071

Merged
garronej merged 1 commit into
keycloakify:mainfrom
hypery2k:feature/improve-password-policy
Oct 21, 2026
Merged

feat: Add missing password policy entries#1071
garronej merged 1 commit into
keycloakify:mainfrom
hypery2k:feature/improve-password-policy

Conversation

@hypery2k
@hypery2k hypery2k commented Oct 20, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Contributor

Add missing password policy entries and update docs for keycloak:

  • passwordHistory: checking it needs the user's stored password hashes, which only the server has. Keycloak reports a reused password after submit as a server error, and keycloakify already displays that
  • forceExpiredPasswordChange: this is an expiry period, not a rule about what the password contains. There's nothing to check

Summary by CodeRabbit

  • New Features

    • Added support for displaying Keycloak 26+ password policy information, including password history and forced password-change settings.

  • Bug Fixes

    • Prevented password history and forced password-change settings from being treated as client-side validation errors, since they cannot be verified without access to stored credentials.

@coderabbitai
coderabbitai Bot commented Oct 20, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b60d4d44-408c-4521-be12-d9854c967e90
📥 Commits

Reviewing files that changed from the base of the PR and between 51579ad and bfaf6b6.

📒 Files selected for processing: 3
  • src/login/KcContext/KcContext.ts
  • src/login/lib/getUserProfileApi/getUserProfileApi.ts
  • src/login/lib/useUserProfileForm.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The PasswordPolicies type adds two optional numeric fields. Password-policy error types exclude those fields from client-side validation error names.

Changes: Password policy types

Layer / File(s) Summary
Password policy types and error names
src/login/KcContext/KcContext.ts, src/login/lib/getUserProfileApi/getUserProfileApi.ts, src/login/lib/useUserProfileForm.tsx		 PasswordPolicies adds optional passwordHistory and forceExpiredPasswordChange fields. Password-policy error names exclude both fields. The source comment identifies Keycloak 26+ as the source of password policy values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: garronej

Merge Risk: ⚪ Minimal · up to bfaf6

No actionable merge-blocking risk was identified in the password-policy type updates.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: adding the missing password policy entries. It also covers the related documentation and type updates.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required C 8000 I, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@garronej
garronej commented Oct 21, 2026
Copy link
Copy Markdown
Collaborator

Thank you @hypery2k,

@allcontributors Please add @hypery2k for code.

@garronej
garronej merged commit aa04226 into keycloakify:main Oct 21, 2026
3 checks passed
garronej added a commit to keycloakify/login-ui that referenced this pull request Oct 21, 2026
@garronej
https://github.com/keycloakify/keycloakify/pull/1071
cc201d8
@allcontributors allcontributors Bot mentioned this pull request Oct 21, 2026
Open
@allcontributors
allcontributors Bot commented Oct 21, 2026
Copy link
Copy Markdown
Contributor

@garronej

I've put up a pull request to add @hypery2k! 🎉

@hypery2k
hypery2k commented Oct 21, 2026
Copy link
Copy Markdown
Contributor Author

you're welcome, thanks for the project. Glad to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hypery2k @garronej
0