Repository navigation
Conversation
mabartos
marked this pull request as ready for review
October 14, 2026 10:53
stianst
self-requested a review
October 14, 2026 12:30
stianst
requested changes
Oct 16, 2026
Collaborator
There was a problem hiding this comment.
Should not use the repository.mainRepository config option, but rather only link PRs to issue if they are in the same repo. Effectively only support Closes/fixes #issue, not the cross-repo approach.
Please extract the part that parses the body to pull out fixed issues into a separate utility, and also provide some unit test for that.
Closes keycloak#94 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Member
Author
|
@stianst Should be ready for another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @stianst