Repository navigation
Conversation
Closes keycloak#54833 Signed-off-by: Peter Zaoral & 8000 lt;pzaoral@redhat.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The safety-critical Azure cleanup depends on unverified GitHub workflow_run timing, rerun-attempt permissions, and asynchronous deletion behavior that require live CI/Azure validation.
No open issues 🎉
What changed in this PR
Adds a fallback Azure cleanup workflow to remove CI resource groups after workflow completion, including cancellation or runner loss scenarios.
Changes:
- Adds a
workflow_runworkflow to locate, delete, and verify Azure resource-group cleanup. - Tags resource groups with repository, run, and attempt metadata.
- Prevents resource-group recreation during provisioning.
- Gates in-job cleanup on successful Azure authentication.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds the Azure login step ID and adjusts existing cleanup conditions. |
.github/workflows/azure-delete.yml |
Adds post-workflow resource-group discovery, deletion, and verification. |
.github/scripts/azure/sql/azure_create_sql.sh |
Adds CI metadata tags when creating Azure resource groups. |
.github/scripts/ansible/azure_vm_manager.sh |
Preserves an existing resource group instead of recreating it. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion pe
30F4
r line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54833