Repository navigation
Conversation
Realm logout-all sends a backchannel logout to every client with an adminUrl, which logged a connection refused warning for localhost:8180. Closes keycloak#54831 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the cleanup of the unused adminUrl in the test realm definitions.
No open issues 🎉
What changed in this PR
Removes the unused, unreachable adminUrl from root-url-client in three test realm definitions, addressing #54831 by preventing unnecessary backchannel logout attempts and connection-refused warnings.
Changes:
- Removes the logout endpoint from both JSON fixtures and the Java realm setup.
- Preserves the client’s root URL, base URL, and redirect URIs.
| File | Description |
|---|---|
tests/base/src/test/resources/org/keycloak/tests/testrealm.json |
Removes root-url-client’s unreachable adminUrl. |
tests/base/src/test/resources/org/keycloak/tests/cli/testrealm.json |
Applies the same cleanup to the CLI fixture. |
tests/base/src/test/java/org/keycloak/tests/account/AbstractRestServiceTest.java |
Removes the matching adminUrl from the account test realm setup. |
Review effort: Balanced
ahus1
marked this pull request as ready for review
November 6, 2026 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unreachable
adminUrlfrom theroot-url-clientin the test realms (testrealm.json,cli/testrealm.jsonandAbstractRestServiceTest).Realm logout-all sends a backchannel logout to every client with an
adminUrl, which logged a connection refused warning forlocalhost:8180as nothing listens there.The tests using this client don't rely on the
adminUrl.Closes #54831