8000 Show the spinner from the first render in KeycloakDataTable by ahus1 · Pull Request #54822 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Show the spinner from the first render in KeycloakDataTable #54822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ahus1 wants to merge 1 commit into
base: release/26.6
Choose a base branch
from
Draft

Show the spinner from the first render in KeycloakDataTable #54822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/libs/ui-shared/src/controls/table/KeycloakDataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
rowsSelectedOnPage.length > 0;
}
}
}, [selectedRows, canSelectAll, rows]);

Check warning on line 151 in js/libs/ui-shared/src/controls/table/KeycloakDataTable.tsx

View workflow job for this annotation

GitHub Actions / UI Shared 

React Hook useEffect has a missing dependency: 'rowsSelectedOnPage.length'. Either include it or remove the dependency array

const updateSelectedRows = (selected: T[]) => {
setSelectedRows(selected);
Expand Down Expand Up @@ -392,7 +392,7 @@
const [selected, setSelected] = useState<T[]>([]);
const [rows, setRows] = useState<(Row<T> | SubRow<T>)[]>();
const [unPaginatedData, setUnPaginatedData] = useState<T[]>();
const [loading, setLoading] = useState(false);
const [loading, setLoading] = useState(true);

const [defaultPageSize, setDefaultPageSize] = useStoredState(
localStorage,
Expand Down Expand Up @@ -486,7 +486,7 @@
),
)
.slice(first, first + max + 1),
[search, first, max],

Check warning on line 489 in js/libs/ui-shared/src/controls/table/KeycloakDataTable.tsx

View workflow job for this annotation

GitHub Actions / UI Shared 

React Hook useMemo has missing dependencies: 'convertToColumns', 'getNodeText', 'isPaginated', and 'unPaginatedData'. Either include them or remove the dependency array
);

useFetch(
Expand Down
Loading
0