Repository navigation
Make OIDCIdentityProvider.BROKER_NONCE_PARAM public - #54741
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change exposing the OIDC broker nonce key for reuse.
No open issues 🎉
What changed in this PR
Exposes the OIDC broker nonce key for reuse by custom providers, authenticators, and mappers, addressing #54740 without changing nonce handling.
Changes:
- Makes
BROKER_NONCE_PARAMpublic while preserving its value andstatic finalmodifiers.
| File | Description |
|---|---|
services/src/main/java/org/keycloak/broker/oidc/OIDCIdentityProvider.java |
Changes the nonce constant’s visibility from private to public. |
Review effort: Balanced
Closes keycloak#54740 Signed-off-by: Maximilian Brodda <QuellcodeWanderer@users.noreply.github.com>
QuellcodeWanderer
force-pushed
the
broker-nonce-param-public
branch
from
November 6, 2026 13:15
6caaa8a to
64a578c
Compare
ahus1
approved these changes
Nov 6, 2026
ahus1
enabled auto-merge (squash)
November 6, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose
publicoverprotectedto match the other constants inOIDCIdentityProvider, which are all public. The value is also stored in the authentication session and in theBrokeredIdentityContext, so code outside the subclass hierarchy, such as authenticators or mappers, may need to read it as well.Only the visibility changes; the constant's value and all nonce handling stay as they are. I did not add a test, because there is no new behaviour to cover.
Closes #54740