8000 fix: clarifying hostname context considerations by shawkins · Pull Request #54681 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: clarifying hostname context considerations - #54681

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss52484
Nov 6, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss52484

Conversation

@shawkins
@shawkins shawkins commented Nov 5, 2026
Copy link
Copy Markdown
Contributor

Updating the docs to be more explicit about how the context path

closes: #52484

closes: keycloak#52484

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested review from a team as code owners November 5, 2026 14:08
Copilot AI balanced review requested due to automatic review settings November 5, 2026 14:08
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the documentation changes clarifying hostname context paths and reverse-proxy forwarding requirements.

No open issues 🎉

What changed in this PR

Clarifies how hostname context paths interact with reverse proxies and Keycloak’s server paths, addressing #52484.

Changes:

  • Explains when proxies must strip a context path versus forward it unchanged with matching http-relative-path.
  • Updates the hostname example with proxy-headers and links to the expanded reverse-proxy guidance.
  • Documents symptoms of mismatched path configurations.
File Description
docs/​guides/​server/​reverseproxy.adoc Separates context-path handling into two approaches and explains forwarding requirements.
docs/​guides/​server/​hostname.adoc Clarifies that hostname paths affect generated URLs, not server listening paths.

Review effort: Balanced

Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the documentation updates clarifying hostname context paths and reverse-proxy handling.

No open issues 🎉

Review effort: Balanced

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar merged commit 0bc6a62 into keycloak:main Nov 6, 2026
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify the documentation for hostname setting with a context path

3 participants

0