Repository navigation
fix homebrew audit step: strict audit plus style with Desc cop excepted - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
homebrewjob fails at the audit step onmain:brew auditrejects--except-copstogether with--strict("Options --except-cops and --strict are mutually exclusive").This splits the audit into two valid steps:
brew audit --strict --skip-style- the full strict formula audit, without its RuboCop part.brew style --except-cops=FormulaAudit/Desc- the RuboCop style checks, run by themselves.Still run: install, test, strict audit, and every style cop.
Exempt: the single
FormulaAudit/Desccop, which wants a capital first letter in the description. The lowercase description is the owner's choice and the formula is unchanged.Only
.github/workflows/build.ymlchanges. Thehomebrewjob on this PR (macOS) is the proof.