Repository navigation
Fix transcription of vector constraints with constant components - #442
Merged
pulsipher merged 1 commit intoSep 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 39 39
Lines 6819 6821 +2
=======================================
+ Hits 6800 6802 +2
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pulsipher
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector constraints with a constant (e.g. a cone with one fixed entry) builds fine but errors during transcription. The constant row is stored as a GenericAffExpr with no variable, then transcription makes it a Float64. This creates mixed elements which is rejected by moi_function inside _process_constraint (src/TranscriptionOpt/transcribe.jl).
Another option is to change
map_expressionbut it looks like that would convert things that are actually Float64 into GenericAffExpr indiscriminately.Fixes #440