Repository navigation
test: 올리브영 timeout 검증의 간헐 실패 수정 - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main의 Coverage 검사에서 올리브영 timeoutMs 전달 테스트가 1ms 경과로 1234 대신 1233을 받아 간헐 실패했습니다. 실제 제한 시간 예산을 계산하는 동작은 정상이며, 정확한 전달값을 검증하는 테스트가 실시간 시계에 의존하고 있었습니다.
정확한 타이머 인자를 검사하는 여섯 테스트 안에서만 Date.now를 고정합니다. 기존 기대값·assertion·운영 코드는 변경하지 않으며 afterEach의 restoreAllMocks로 복원합니다.
1ms씩 진행하는 시계로 기존 실패를 재현한 뒤 수정했습니다. 전체 3,685개 테스트/check와 커버리지100% 통과, 독립 리뷰 완료입니다.