8000 fix: 올리브영 준비 시 부가 리소스 대기 방지 by hmmhmmhm · Pull Request #273 · hmmhmmhm/daiso-mcp · GitHub
[go: up one dir, main page]
Skip to content

fix: 올리브영 준비 시 부가 리소스 대기 방지 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmmhmmhm merged 1 commit into from
Oct 18, 2026
Merged

fix: 올리브영 준비 시 부가 리소스 대기 방지 #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/relay/lifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ export function createBrowserLifecycle(
}),
32000,
);
await bounded(page.waitForURL('**/store/**', { timeout: 30000 }), 32000);
await bounded(
page.waitForURL('**/store/**', { waitUntil: 'domcontentloaded', timeout: 30000 }),
32000,
);
if (closed || owner !== sessionOwner) throw new Error('Browser lifecycle unavailable');
emit('ready');
timer = setInterval(() => {
Expand Down
18 changes: 18 additions & 0 deletions tests/relay/lifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,21 @@ it('소멸 확인 뒤 close 거절은 다음 요청의 새 브라우저 실행
expect(life.status()).toMatchObject({ state: 'ready', pages: 1 });
await life.close();
});

it('문서가 준비됐으면 느린 부가 리소스의 load 이벤트 없이 조회를 시작한다', async () => {
vi.useFakeTimers();
const f = fixture();
f.page.waitForURL.mockImplementation((_url, options) => {
if (options.waitUntil === 'domcontentloaded') return Promise.resolve();
return new Promise((_resolve, reject) => {
setTimeout(() => reject(new Error('부가 리소스 load 대기 만료')), 30000);
});
});
const life = createBrowserLifecycle(f.launch);
const ready = life.start().then(() => true, () => false);
await vi.advanceTimersByTimeAsync(30000);
expect(await ready).toBe(true);
expect(life.status()).toMatchObject({ state: 'ready', pages: 1 });
await expect(life.run('/p', {})).resolves.toEqual({ status: 'SUCCESS' });
await life.close();
});
Loading
0