Repository navigation
ci: add local Mac fallback and patch vulnerable build dependencies - #106
Merged
Merged
Conversation
hmmhmmhm
marked this pull request as ready for review
October 6, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI prefers
personal-mac-aka-browserafter a short GitHub-hosted status check, retaining macos-latest when the local runner is offline/missing or the status query fails. Busy local runners stay eligible; external PRs and non-owner events remain hosted. The repository-scoped Administration read-only status secret is installed and expires 2027-01-04.Fix the existing release-readiness audit failure (75 findings) while preserving all checks and the Castlabs Widevine distribution. Update Castlabs Electron 39.8.10+wvcus to 42.11.10+wvcus and match build.electronVersion; update electron-builder 26.15.3, Vite 8.0.16, Vitest 4.1.11, and patched transitive dependencies. Vitest 3 receives no fix for the current advisory. Castlabs' official extract-zip replacement and global-agent 4.1.3's removal of roarr eliminate two dependencies with unpublished original-package fixes.
Validation: complete dependency audit now reports zero findings. Frozen lockfile alignment, whitespace checks and independent dependency review are tracked with the full PR CI: https://github.com/hmmhmmhm/aka-browser/actions/runs/37417641266. Selector/trust/shared-slot tests and actionlint passed; token-based named local smoke passed. An actual offline smoke verified hosted macOS selection: https://github.com/hmmhmmhm/aka-browser/actions/runs/37398008316. Full app tests/builds run in GitHub Actions, not in another local installation.
Electron major update requires DRM review: Widevine integration and EVS/notarization scripts remain unchanged, but production DRM playback needs an EVS-signed build and was not exercised. Existing persistent licenses may require refetching across CDM system-ID changes. Official release: https://github.com/castlabs/electron-releases/releases/tag/v42.11.10%2Bwvcus.
Selection is a preflight decision; a disconnect after queueing or during execution does not migrate that job to cloud. Build/test failures do not trigger cloud retries.