8000 chore: prep 0.1.7 release, and correct the README's slideshow docs by msample · Pull Request #41 · gominimal/kittyview · GitHub
[go: up one dir, main page]
Skip to content

chore: prep 0.1.7 release, and correct the README's slideshow docs - #41

Merged
msample merged 2 commits into
mainfrom
mike/prep-0.1.7
Sep 22, 2026
Merged

chore: prep 0.1.7 release, and correct the README's slideshow docs#41
msample merged 2 commits into
mainfrom
mike/prep-0.1.7

Conversation

@msample
@msample msample commented Sep 22, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Member

Two things, since the second is what the first releases.

1. README corrections

Checking the README against the slideshow changes turned up three errors, one of them ours and two pre-existing.

The tmux paragraph was ours, and now wrong. It described the alternate-screen rebuild as what every slide change does, with its flash presented as the price of reliability. #40 replaced that with the tmux refresh-client repaint, which costs nothing visible. Rewritten: the repaint is the normal path, the rebuild is the fallback where a repaint cannot reach (GNU screen, nested tmux) or when r asks for it, and the transmission verification now reads as its own point rather than a parenthesis inside the flash's justification. The ghostty#13056 reference is kept and folded in -- the wrong-size rendering it tracks is the same defect the repaint works around.

The key table claimed PgUp/PgDn were aliases for Home/End. They are not -- they navigate by one slide:

b"5" => Key::Prev,         // PgUp
b"6" => Key::Next,         // PgDn
b"1" | b"7" => Key::First, // Home variants
b"4" | b"8" => Key::Last,  // End variants

page_keys_navigate has asserted this all along. Anyone taking the table at its word would have thought the keys broken. This predates #40.

Ctrl-D quits and was undocumented (0x03 | 0x04 | b'q' | b'Q' => Key::Quit).

2. Release prep

Patch bump -- one bug fix plus the test tooling that found it. Following 3f60d56 (the 0.1.6 prep) exactly:

File Change
Cargo.toml 0.1.6 -> 0.1.7 (the release workflow gates the tag on this)
Cargo.lock, fuzz/Cargo.lock kittyview entry to 0.1.7
CHANGELOG.md ## upcoming becomes ## 0.1.7
README.md, SECURITY.md --source-ref refs/tags/ pins to v0.1.7 (1 + 2 occurrences)

Both lockfiles were regenerated with cargo update -p kittyview rather than hand-edited; the diff is one line each, with no unrelated dependency churn.

Verification

  • kittyview --version reports 0.1.7 -- the check the v0.1.4 incident was about, where the tag shipped binaries reporting 0.1.3
  • 237 tests pass, clippy clean, fmt clean
  • no ## upcoming section and no refs/tags/v0.1.6 pins remain

After merge

This only preps the release. Publishing still needs the v0.1.7 tag pushed, which is what triggers release.yml; the workflow re-checks the tag against Cargo.toml before building anything.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Release

    • Updated the package and release documentation to version 0.1.7.

  • Documentation

    • Updated download and artifact verification examples for release 0.1.7.
    • Clarified slideshow keyboard controls, including Page Up, Page Down, and Backspace.
    • Added guidance for repainting slides in tmux and Ghostty, including retry and rebuild behavior.

msample and others added 2 commits September 22, 2026 06:46
@msample @claude
docs: correct the README's slideshow description and key table
29f84c9 
Three things were wrong.

The tmux paragraph still described the alternate-screen rebuild as what
every slide change does, with its flash presented as the price of
reliability. That was replaced by the `tmux refresh-client` repaint, which
costs nothing visible; the rebuild now runs only where a repaint cannot
reach -- GNU screen, and tmux nested in another multiplexer -- and when
`r` asks for it. The transmission verification is independent of either
and now reads as its own point rather than a parenthesis inside the
flash's justification.

The key table claimed PgUp and PgDn were aliases for Home and End. They
navigate by one slide, not to the ends: `page_keys_navigate` asserts
`CSI 5~` is Prev and `CSI 6~` is Next. Anyone taking the table at its word
would have thought the keys broken.

Ctrl-D quits and was undocumented.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@msample @claude
chore: prep 0.1.7 release
71f0afc 
Version to 0.1.7 in Cargo.toml and both lockfiles' kittyview entries, the
changelog's upcoming section becomes the 0.1.7 section, and the README and
SECURITY.md verification examples pin the new tag.

The one change: slideshow images render fully under tmux without the
inter-slide flash, by repainting the client with `tmux refresh-client`
instead of rebuilding through the pane's main screen. The probe variants
that isolated it ship with it.

Lockfiles were regenerated with `cargo update -p kittyview` rather than
hand-edited, so neither picked up unrelated dependency churn.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai
coderabbitai Bot commented Sep 22, 2026 •
edited
Loading
Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

8000 Review profile: CHILL

Plan: Essentials

Run ID: 74d18333-9e7f-4309-9e8b-8e10d6f8b3b4

📥 Commits

Reviewing files that changed from the base of the PR and between 7bfae7c and 71f0afc.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • fuzz/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CHANGELOG.md
  • Cargo.toml
  • README.md
  • SECURITY.md

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

📝 Walkthrough

Walkthrough

The release metadata and verification examples now use version 0.1.7. The README also documents updated slideshow controls and repaint behavior for tmux and Ghostty.

Changes

Version 0.1.7 release updates

Layer / File(s) Summary
Release metadata and verification references
CHANGELOG.md, Cargo.toml, README.md, SECURITY.md		 The release heading, package version, and verification examples now reference version 0.1.7.
Terminal behavior documentation
README.md		 The README documents Page Down/Page Up controls, quit keys, tmux repaint and fallback behavior, Ghostty repaint requirements, and tmux passthrough verification and retries.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 71f0a

This release updates version metadata and documents slideshow controls and terminal repaint behavior; it is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes both primary changes: preparing the 0.1.7 release and correcting the README slideshow documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@msample
msample merged commit d4416c2 into main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@msample
0