Repository navigation
fix(content-bubble): decode text artifacts as UTF-8 - #552
Merged
copybara-service[bot] merged 1 commit intoNov 6, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
getTextContent() in ContentBubbleComponent returned atob(base64) directly, rendering the UTF-8 bytes of multibyte text artifacts as Latin-1 characters in the inline chat preview (e.g. CJK text shows as mojibake). The same bug was fixed for the Artifacts tab in google#478; this applies the identical TextDecoder-based decode to content-bubble and adds unit tests mirroring the artifact-tab spec. Fixes google#551
magiccao
force-pushed
the
fix/content-bubble-utf8-decode
branch
from
October 22, 2026 02:23
f5d3213 to
26c1a9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTextContent()inContentBubbleComponentreturnedatob(base64)directly, so the inline artifact preview in the chat view rendered the UTF-8 bytes of multibyte text artifacts as Latin-1 characters (CJK text shows as mojibake). ASCII content was unaffected.TextDecoder-based decode that was merged for the Artifacts tab in fix(artifact-tab): decode text artifacts as UTF-8 #478 tocontent-bubble.component.ts, and adds unit tests mirroring the artifact-tab spec (multibyte UTF-8, ASCII, no-comma and empty data URL cases).getTextContent()incontent-bubble.component.ts) was left unchanged.Reproduction
Save a text artifact containing multibyte content from a tool:
In
adk web, the inline preview under the tool call shows# æå ...while the Artifacts tab shows the same artifact correctly.Test plan
npm ci && npx ng test --watch=false --browsers=ChromeHeadless— full suite: 830 passing (incl. the 5 newcontent-bubble.component.spec.tstests), 37 skipped, 0 failures# 报告 / 0.1.1 版本回归测试通过。correctly🤖 Generated with Claude Code