Repository navigation
chore(0002): quality surface stabilization - #35
Closed
Ryan-AI-Studios wants to merge 9 commits into
Closed
Ryan-AI-Studios wants to merge 9 commits into
Ryan-AI-Studios wants to merge 9 commits into
Conversation
added 9 commits
August 2, 2026 08:17
Add uv dev toolchain (ruff, basedpyright, pytest), project CI with Node-24-ready Actions, gitignore for local agent/conductor governance, offline smoke tests, and docs/planner-handoff.md for cold-start planners. Includes small gimp_mcp_server typing/format fixes for the new gate.
Document 0001 bootstrap complete, 0002 quality stabilization as next, and the full path through 0028 final product polish.
Move test_add_text_metadata and continuous_edit_test (with fixtures) out of pytest discovery paths so offline collection only sees unit tests. Update pytest norecursedirs and gitignore output path. Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Drop temporary product-Python extend-exclude entries and apply ruff format across the intentional quality surface (server, plugin, demos, scripts, tests). Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Auto-fix demos/scripts; manual RUF034 on plugin; ASCII-ize non-plugin unicode for RUF001/002. Honest pyproject: plugin per-file E402/I/RUF001/002 (no import reorder), drop dead T201 ignore, retain B904+E501 with comments, basedpyright scripts exclude, pre-commit ruff-check then ruff-format. Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Branch protection on main is absent (no required Lint check name). Dual workflows double-ran ruff on every PR. Keep ci.yml as the single quality gate. Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Document post-0002 lint vs types surface, plugin excludes, lockfile SoT for mcp/fastmcp, type-hardening dials, scripts layout, and ci.yml as sole CI gate. Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (15)
WalkthroughThe pull request adds CI quality checks, expands Python tooling configuration, documents repository workflows, adds smoke tests, and applies Ruff-style formatting across the MCP server, GIMP plugin, and supporting scripts. Socket handlers now catch ChangesRepository quality foundation
Runtime and script consistency
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Opened against upstream by mistake; quality-surface work is for Ryan-AI-Studios fork track 0002. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements conductor track 0002-QualitySurfaceStabilization: honest full-surface ruff/format, script layout hygiene, pre-commit/CI cleanup, basedpyright policy, and local ledgerful rules.toml fix.
Changes
tests/→scripts/ruff format+ruff checkacross product Python (plugin included with E402/I/RUF001/RUF002 per-file policy)pyproject: remove temp product excludes; retain global B904/E501 with deferred debt notesruff-checkthenruff-format@ v0.16.1lint.yml;ci.ymlis sole quality SoTVerification (local)
uv run ruff check ./ruff format --check ./basedpyright/ offline pytest (2) — greenledgerful verify --scope full— greenNotes
.ledgerful/rules.tomlis gitignored; fixed locally (duplicaterequired_verifications)Ledger: 83598dee-78b5-4c0a-8975-96a7b5cd15c4
Summary by CodeRabbit
Quality & Reliability
Documentation
Developer Experience