8000 GOATS-1476: Share TNS bot credentials with approved group members by miguelgomezgomez · Pull Request #769 · gemini-hlsw/goats · GitHub
[go: up one dir, main page]
Skip to content

GOATS-1476: Share TNS bot credentials with approved group members - #769

Merged
miguelgomezgomez merged 2 commits into
mainfrom
GOATS-1476/share-tns-bot-credentials-with-approved-group-members
Sep 29, 2026
Merged

GOATS-1476: Share TNS bot credentials with approved group members#769
miguelgomezgomez merged 2 commits into
mainfrom
GOATS-1476/share-tns-bot-credentials-with-approved-group-members

Conversation

@miguelgomezgomez
@miguelgomezgomez miguelgomezgomez commented Sep 29, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Checklist

  • Added a release note in doc/changes using the PR number.

github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 29, 2026
View reviewed changes
Comment thread src/goats_tom/views/tns_access_management.py
allowed_hosts={request.get_host()},
require_https=request.is_secure(),
):
return redirect(referer)
@codecov
codecov Bot commented Sep 29, 2026
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.33841% with 153 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.96%. Comparing base (793d8b3) to head (ed99cb1).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/goats_tom/views/tns_report.py 56.31% 43 Missing and 2 partials ⚠️
src/goats_tom/emails.py 26.08% 34 Missing ⚠️
src/goats_tom/tns_membership.py 85.45% 10 Missing and 6 partials ⚠️
...tom/migrations/0003_remove_tnslogin_group_names.py 38.09% 12 Missing and 1 partial ⚠️
src/goats_tom/middleware/tns.py 76.31% 6 Missing and 3 partials ⚠️
src/goats_tom/views/tns_access_management.py 89.28% 7 Missing and 2 partials ⚠️
src/goats_tom/models/tns_submission_record.py 82.35% 6 Missing ⚠️
src/goats_tom/templatetags/goats_tns_extras.py 85.36% 3 Missing and 3 partials ⚠️
src/goats_tom/forms/tns_join_request.py 89.47% 2 Missing and 2 partials ⚠️
src/goats_tom/visibility.py 71.42% 2 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   87.40%   87.96%   +0.55%     
==========================================
  Files         372      398      +26     
  Lines       16988    18822    +1834     
  Branches      940     1044     +104     
==========================================
+ Hits        14848    16556    +1708     
- Misses       1957     2060     +103     
- Partials      183      206      +23

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miguelgomezgomez
miguelgomezgomez merged commit ef55da0 into main Sep 29, 2026
1 check passed
@miguelgomezgomez
miguelgomezgomez deleted the GOATS-1476/share-tns-bot-credentials-with-approved-group-members branch September 29, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguelgomezgomez @github-advanced-security
0