Repository navigation
compiler: rename Go conflictful symbols - #1205
Merged
Merged
Conversation
oleavr
requested changes
Jan 15, 2026
oleavr
reviewed
Jan 15, 2026
Member
|
I tweaked and simplified a bit. Does this still work for you? |
Member
Author
|
Thanks @oleavr for the tweaks, that is looking great to me. It is working okay now and can be merged. If in the future there happens to be some symbols that are causing link time failure, I will provide some small tutorial in the repo how to get rid of those symbols (the same algorithm used here) because we can't really sanitize every possible symbol combination that can occur. |
Member
|
@NSEcho Yay, thanks for testing! It looks like this is causing regressions on Windows (MSVC), so will have to figure that out before we can land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more logic to remove troublesome Go symbols which is mostly the case when cross-compiling for Windows on Linux using mingw.
Will see now how test goes and if there is anything that needs to be fixed.