Repository navigation
chore(deps): bump minor deps and typescript 6 - #9
Merged
Merged
Conversation
reka-ui 2.10.1, tailwindcss 4.3.3, vite 8.1.5, @vitejs/plugin-vue 6.0.8, vue-tsc 3.3.8, vite-plugin-vue-devtools 8.2.1, @types/node ^25, typescript 6.0.3, @vue/tsconfig 0.9.1. TS 6 adjustments (mirrored from the shell repo): - re-pin noUncheckedIndexedAccess: @vue/tsconfig 0.9.1 dropped it from its base, which would silently d 8000 isable the check. - remove deprecated baseUrl (TS5101); paths entries resolve relative to this tsconfig without it. - ambient declaration for @fontsource-variable/inter (CSS-only package) to satisfy TS 6's TS2882 side-effect-import check. type-check and build pass.
3 tasks
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 089f71faaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dependencies": { | ||
| "@internationalized/date": "^3.12.2", | ||
| "@tailwindcss/vite": "^4.2.2", | ||
| "@tailwindcss/vite": "^4.3.3", |
There was a problem hiding this comment.
The manifest changes ten dependency specifiers without updating pnpm-lock.yaml, whose importer still contains the old ranges. The checked CI workflow runs pnpm install --frozen-lockfile at .github/workflows/ci.yml:20; pnpm help install documents that this option fails when a lockfile update is needed, and running that exact command on this commit produces ERR_PNPM_OUTDATED_LOCKFILE listing all ten mismatches. Regenerate and commit the lockfile so CI and fresh frozen installs can proceed.
Useful? React with 👍 / 👎.
The ui repo is also consumed standalone (its CI runs pnpm install --frozen-lockfile); the shell-repo workspace install does not refresh this lockfile, so regenerate with --ignore-workspace.
qqqqqf-q
added a commit
to qqqqqf-q/Memoh
that referenced
this pull request
Jul 28, 2026
qqqqqf-q
added a commit
to qqqqqf-q/Memoh
that referenced
this pull request
Jul 29, 2026
Points at felinics/ui#9 (reka-ui 2.10.1, vite 8.1.5, tailwind 4.3.3, typescript 6.0.3 with the same noUncheckedIndexedAccess / baseUrl / fontsource adjustments). Land felinics/ui#9 before this PR.
qqqqqf-q
added a commit
to qqqqqf-q/Memoh
that referenced
this pull request
Jul 29, 2026
qqqqqf-q
added a commit
to qqqqqf-q/Memoh
that referenced
this pull request
Jul 29, 2026
felinics/ui#9 squash-merged as f499363; re-point from the review branch (b30a27d, now dangling) so the submodule reference resolves from main.
qqqqqf-q
added a commit
to felinics/Memoh
that referenced
this pull request
Jul 29, 2026
…ue-router 5, katex, markstream-vue) (#870) * chore(deps): bump minor frontend deps (batch 1) vue 3.5.40, vite 8.1.5, tailwindcss 4.3.3, vue-i18n 11.4.8, vitest 4.1.10, mermaid 11.16.0, echarts 6.1.0, electron-builder 26.15.3, plugin-vue 6.0.8, vue-tsc 3.3.8, reka-ui 2.10.1 (ui submodule, pending its own commit), cronstrue 3.24.0, cron-parser 5.6.2, vue-virtual 3.13.34, vite-plugin-vue-devtools 8.2.1, stream-markdown 0.0.16, @types/node ^25. Also fixes one new vue-tsc 3.3 strictness error in step-frame.vue (bodyClass: unknown -> HTMLAttributes['class']). Known residual: electron-builder-squirrel-windows stays at 26.8.1 inside electron-builder 26.15.3's peer-optional cycle (pnpm overrides do not apply); affects only future Windows installer builds. * chore(deps): bump eslint to 10 (batch 2) eslint 10.8.0, eslint-plugin-vue 10.10.0, vue-eslint-parser 10.4.1, typescript-eslint 8.65.0, lint-staged 17.2.0. pnpm lint stays clean. * chore(deps): bump typescript to 6.0.3 @vue/tsconfig 0.9.1 across web/desktop/ui. Two TS 6 adjustments: - re-pin noUncheckedIndexedAccess in all three tsconfigs: @vue/tsconfig 0.9.1 dropped it from its base, which would have silently disabled the check (typecheck errors fell 471 -> 412 before re-pinning). - remove deprecated baseUrl (TS5101) from desktop/ui tsconfigs; paths values carry explicit './' prefixes instead (TS5090). - add ambient declarations for @fontsource-variable/inter (CSS-only package, no shipped types) to satisfy TS 6's TS2882 side-effect-import check; also clears one pre-existing TS2307 in web. Verification: web 466 typecheck errors vs 471 baseline (5 fixed, 0 new), desktop and ui typecheck clean, eslint clean, vitest parity (same 5 pre-existing desktop failures; one previously failing test file now passes under TS 6). * chore(deps): bump vue-router to 5.2.0 pinia/@pinia/colada peers of vue-router 5 are optional, so this lands independently. pinia 4 and @pinia/colada 1 were evaluated in the same session and deferred: both independently break vue-tsc's template typing in this repo (~1290 false Property '$t' does not exist errors across 98 files, program-wide loss of vue-i18n's ComponentCustomProperties augmentation under VLS), and colada 1 additionally changes type inference between defineQueryOptions and useQuery, breaking @memohai/sdk's generated colada.gen.ts call sites (DefineQueryOptionsTagged no longer assignable). Runtime signatures are unchanged; this is a type-level incompatibility needing dedicated investigation or upstream (@hey-api/openapi-ts) support. Verification: web typecheck 466 errors, identical to baseline; eslint clean; vitest parity (same 5 pre-existing desktop failures). * chore(deps): bump stream-monaco to 0.0.49 shiki 4 and monaco-editor 0.56 were evaluated and reverted in the same session: the entire markdown/stream stack (stream-monaco pins shiki ^3.23 and peers monaco <0.56, shiki-stream uses @shikijs/core ^3) is still on shiki 3, so a direct shiki 4 bump only adds a second copy without removing the first, and monaco 0.56 violates stream-monaco's peer range (plus it drops the stickyScrollContribution deep import this repo uses). Defer both until stream-monaco supports them. Typecheck and vitest parity. * chore(deps): bump katex to 0.18.1 Crosses 0.17; typecheck and vitest parity. Formula rendering regression check left to visual QA. * chore(deps): bump markstream-vue to 1.0.7 (from 1.0.1-beta.5) Beta to stable. New optional peers (d2, infographic, stream-diffs) are not installed and were not used before; katex/mermaid/stream-monaco/ stream-markdown peers all satisfied. Typecheck and vitest parity. Chat markdown rendering regression check left to visual QA. * chore(ui): bump @felinic/ui gitlink for deps + TS 6 alignment Points at felinics/ui#9 (reka-ui 2.10.1, vite 8.1.5, tailwind 4.3.3, typescript 6.0.3 with the same noUncheckedIndexedAccess / baseUrl / fontsource adjustments). Land felinics/ui#9 before this PR. * chore(ui): bump gitlink for standalone lockfile fix in felinics/ui#9 * fix(web): retarget code-block override to markstream 1.0.7 class Found by post-upgrade review: markstream-vue 1.0.7 renamed .code-block-content to .code-block-shell-content (folding now uses a --collapsed modifier instead of max-height), leaving the override a dead rule and silently dropping line-height: 1.5 in chat code blocks. Font properties survived via the parent selector's inheritance; retargeting restores line-height only. * chore(ui): point gitlink at merged memohai/ui main felinics/ui#9 squash-merged as f499363; re-point from the review branch (b30a27d, now dangling) so the submodule reference resolves from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to the Memoh shell-repo dependency upgrade. Bumps:
TS 6 adjustments (same as shell repo)
noUncheckedIndexedAccess— @vue/tsconfig 0.9.1 dropped it from its base; without the pin the check silently turns off.baseUrl(TS5101) — paths resolve relative to the tsconfig without it.@fontsource-variable/inter— CSS-only package with no shipped types; TS 6 flags untyped side-effect imports (TS2882).Verification
pnpm run type-checkcleanpnpm run buildcleanLand this before the shell-repo PR so its gitlink resolves.