Repository navigation
fix(settings): inset the section footer hairline - #8
Merged
qqqqqf-q merged 1 commit intoAug 20, 2026
Merged
Conversation
Ported from memohai/Memoh PR #860 (apps/web settings/section.vue, on fix/mcp-state-model): the footer's top divider becomes an inset hairline aligned with content padding (same logic as row dividers) instead of a full-bleed border-t, and the double-hairline guard moves from nth-last-child(2) to (3) since the hairline div is now the footer's own first child.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from felinics/Memoh#860's shared
settings/section.vuechange, which has to live here since #6 turned the apps/web file into a re-export shim over this component.border-t→ inset hairline (mx-4, aligned with content padding, same logic as row dividers)nth-last-child(2)→(3)(the hairline div is now the footer band's own preceding sibling)Companion of felinics/Memoh#860. After this lands, the main repo needs a gitlink bump for the fix to reach the app; until then the app keeps the current full-bleed divider (no regression vs today).
Test plan
#footerslot — divider inset matches row dividers, no double line above the footer