Repository navigation
fix(completions): preserve streamed reasoning detail order - #118
Merged
Merged
Conversation
Member
Author
|
related view this |
ix64
added a commit
to ix64/twilight
that referenced
this pull request
Oct 13, 2026
…e stream" This reverts commit 9821109. Upstream felinics#118 merges reasoning_details in wire order and supersedes the type+index merge here; the late-piece fix is proposed separately in felinics#122. This branch goes back to the errorformat and openai models fixes only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_detailsin wire order instead of treatingindexas a stable cross-chunk identityreasoning.textandreasoning.summaryfragmentsTests
go test ./...