Repository navigation
Conversation
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 14:43
1e88fa5 to
868cd2f
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 14:55
868cd2f to
02a433f
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
2 times, most recently
from
October 3, 2026 15:47
0ffaeb8 to
6e7eeb7
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 16:05
6e7eeb7 to
c4a0680
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 16:37
c4a0680 to
d5bcd38
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 16:54
d5bcd38 to
15744a6
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 17:04
15744a6 to
91e53b0
Compare
Fodesu
force-pushed
the
feat/agent-runtime-loop-executor-tests
branch
from
October 3, 2026 17:11
91e53b0 to
399fe16
Compare
Fodesu
marked this pull request as ready for review
October 3, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused tests for the Loop/executor boundary and effect retention. The suite concentrates on the handoff between a persisted Executing target and an executor that may accept, retry, lose, or later settle the corresponding Assignment.
Coverage
executor_test.godrives model and tool Assignments through validation, start barriers, dispatch, outcome delivery, and replay. It verifies that the Loop matches an Outcome by the stable EffectID, settles only the currently Executing target, and drops outcomes for a settled or otherwise stale effect. The cases cover cancellation and unknown outcomes so a potentially completed external tool is not incorrectly retried as a known failure.Retention tests exercise what remains addressable while a Run or effect is in progress. They check that frozen request/result bodies and execution records remain available through the settlement boundary, while provisional observations do not become durable Run facts. The tests also cover the relationship between worker generations, redispatch/recovery, and the Loop’s obligation to keep an effect Executing until an explicit outcome or recovery command settles it.
The test setup uses the loop executor contracts and public store operations rather than bypassing the start/dispatch protocol. This makes failures meaningful for local and remote executor implementations alike and protects the invariant that persistence is the authority while execution is an external effect.
Scope
This is a test-only PR; it introduces no runtime behavior.