Repository navigation
feat(ui): bump @felinic/ui for the spec-driven showcase - #839
Conversation
The ui submodule gains its self-built spec-driven showcase (replacing Storybook): shell, foundations pages, 23 component specs, stage view modes, and light/dark side-by-side. The root lockfile drops the storybook dependency tree and adds the two showcase dev font deps (@fontsource-variable/inter, misans-vf).
The SettingsRow/SettingsSection implementations moved into the library (src/components/settings) so the showcase composes them; these two files re-export from '@felinic/ui' to keep the 64 call sites untouched. Call-site migration is a deliberate follow-up. Also bumps the @felinic/ui pointer.
…3 shims, copy via props - 23 host files become re-export shims (settings/*, settings-shell, status-dot, form-dialog-shell, inline-loading-row, pane-placeholder, persona-tile, callout-banner, diff-title-bar, device-code-panel, confirm-delete-dialog, confirm-popover, composables/useClipboard) — every call site keeps working unchanged - i18n sweeps for the three components whose copy is now prop-driven: DeviceCodePanel (provider-form passes the 5 label props), ConfirmDeleteDialog (5 sites gain cancel-label/confirm-label), ConfirmPopover (26 usages across 14 files gain cancel-text/confirm-text where they relied on the old fallback — behavior byte-identical) - style.css: swap-forward/swap-back classes move to the library (pointer comment left behind) - packages/ui gitlink bumps to the lift commit
- panel-preview/add-provider: partial vi.mock('@felinic/ui') now covers
PanePlaceholder/FieldStack — they moved into the library, so the mocks
swallowed them through the host shims (importOriginal spread /
Passthrough stub matching each file's own style)
- model-list-row: widen the test timeout — the shim import pulls the whole
library barrel through the transform pipeline, which can exceed 5s
under full-suite load (passed solo, timed out in the full run)
d50c7c9 to
afa2a13
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa2a130c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </p> | ||
| </div> | ||
| </div> | ||
| <script lang="ts"> |
There was a problem hiding this comment.
script setup re-export shims
This and the other newly introduced component shims use ordinary <script lang="ts">, but the Web package explicitly requires <script setup> exclusively. Since these shims only preserve legacy relative imports, migrate their call sites to import the lifted components directly from @felinic/ui and delete the shims rather than adding a repository-wide exception across 25 components.
AGENTS.md reference: apps/web/AGENTS.md:L540-L544
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The plain-<script> form is deliberate, not a style exception: <script setup> cannot express a transparent component re-export (no default export; a wrapper template would change named-slot forwarding and attrs fallthrough). These shims are temporary plumbing whose only job is to keep 64+ existing call sites untouched in this PR — migrating those call sites to import from @felinic/ui directly and deleting the shims is the planned follow-up, now tracked in #862.
…p the shims (#904) The 26 re-export shims (25 components + useClipboard) were a transition device from the #839 lift — every call site now imports the named export from @felinic/ui, so the shims' job is done. Mechanical rewrite: 306 import sites + 8 test files' vi.mock targets. No behavior change. Closes #862.
packages/uipointer must be updated to the resulting main commit, then this PR is ready.Summary
Hosts the new @felinic/ui showcase (felinics/ui#6) in the main repo:
packages/uigitlink → the showcase branch: a self-built, spec-driven component showcase replacing Storybook (collapsible-sidebar shell + foundations pages + 23 component specs; doc-spine component pages with live playground, light/dark, 5 schemes)components/page-shell,components/section-group,components/settings/row,components/settings/section) — every existing call site keeps working unchanged; migrating imports to@felinic/uidirectly is a follow-up PRpnpm-lock.yaml: drops the Storybook dependency tree (−1392 lines), adds the showcase's two dev font deps (@fontsource-variable/inter,misans-vf— both already host-app dependencies)No application behavior changes.
Test plan
pnpm installregenerates the lockfile cleanly against the bumped submodule#/alias TS2307, identical count on main)git submodule update+pnpm installfrom a clean checkout