Repository navigation
fix: store the returned handle for posix, wasm and redox menu items - #442
Merged
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be a
2E30
pplied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_menu_itemon the posix, wasm and redox backends storeditem_counterafternext_item_handle()had already bumped it, so each item kept the returned handle + 1 andremove_itemwith that handle removed the previous item or nothing. Store the handle that is returned instead, with a test inposix/common.rsthat fails on master.This only covers the wasm/redox bullet of #417 (posix had the same line); the Windows and macOS menu items are untouched.
Part of #417