Repository navigation
fix(macos): treat keycode 128 as unknown (off-by-one bounds) - #427
Merged
Merged
Conversation
KEY_MAPPINGS has 128 entries (0..127). The previous bound check used `key > 128`, so keycode 128 indexed past the end of the table inside an ObjC callback and could panic. Fixes emoon#413
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS,
key_callbackusedif key > 128before indexingKEY_MAPPINGS: [Key; 128]. Keycode 128 was treated as in-bounds and panicked with an out-of-range index inside anextern "C"ObjC callback.The check is now
key < 0 || key >= 128, mapping those codes toKey::Unknown.Fixes #413
Test plan
cargo checkon the branchKEY_MAPPINGSlength (128) against the new bound