Repository navigation
SA1019: detect deprecated dot-imported objects - #1825
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SA1019 checks deprecated objects referenced through dot imports, including function references, while preserving qualified selector diagnostics.
Struct literal field keys are handled once by the existing synthetic selector path. The review follow-up corrects the ancestor-stack index so the added identifier traversal does not emit a second, incorrectly named diagnostic for these keys. Added dot-import function and struct-field regression coverage.
Validation: the previous PR head failed the existing Go 1.0 fixture with unexpected pkg.D diagnostics; after the ancestor fix, go test ./staticcheck/sa1019 passed all seven tests. gofmt and git diff --check passed.