Repository navigation
ir: stop sanity checking invalid range iterator - #1815
Closed
dajiaohuang wants to merge 2 commits into
Closed
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
Author
|
Withdrawing after reassessing necessity. The actual range builder supplies a Range iterator; no supported source input or real transformation has been established that reaches the malformed Next case addressed here. Sanity checking is an internal debugging pass and production callers already deliberately panic on a failed check. The isolated invalid-IR case does not establish a necessary repair to actual supported use. This withdrawal does not claim that the malformed representation is valid or that every debugging diagnostic is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sanity checking a malformed
Nextinstruction whoseIteris not an*Range, report the invariant violation and stop checking that instruction. Continuing to inspectrng.Xdereferences a nil pointer and panics instead of returning a failed sanity check.Validation: static control-flow review and
git diff --check. No tests were added or run.