Repository navigation
Limit generated marker detection to file headers - #1771
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-file detection reads actual line comments before the package clause, matching Go's generated-file convention. Parse only the package clause and comments instead of scanning arbitrary source lines, while retaining recognized generator names and the legacy cgo marker.
The review follow-up removes the unsupported first-ten-lines cutoff, so generated markers following a long license header are recognized. Indented package clauses and marker-like text inside a block comment cannot trick the detector into treating a handwritten file as generated.
Validation: go test ./analysis/facts/generated passed (eight tests), including long-header, indented-package, block-comment, legacy-cgo and existing cases; gofmt and git diff --check passed.
Convention: https://go.dev/s/generatedcode; parser approach: https://pkg.go.dev/go/ast#IsGenerated.