Repository navigation
Avoid SA1006 fixes with missing errors import - #1769
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SA1006 retains its diagnostic for dynamic fmt.Errorf calls and offers an errors.New replacement only when a usable errors package import is visible at that call. It preserves the actual alias in the diagnostic file and avoids borrowing an import from another file or using a locally shadowed alias.
Regression/golden fixtures cover a usable alias, another source file without the import, and local shadowing. This change does not add or remove imports.
Validation: go test ./staticcheck/sa1006 passed (two tests); gofmt and git diff --check passed.