Repository navigation
simple: preserve import aliases in suggested fixes - #1763
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S1004 and S1028 preserve package qualifiers from matched bytes.Compare and fmt.Sprintf calls when generating suggested fixes. Aliased-import fixtures cover both checks.
Dot-imported functions keep their diagnostics without an unsafe suggested fix. New dot-import regression fixtures reproduced interface-conversion panics on the previous PR head; checked selector handling fixes both crashes.
Validation: go test ./simple/s1004 ./simple/s1028 passed (four tests); gofmt and git diff --check passed. No whole-repository test claim.