Repository navigation
st1023: avoid invalid generic method value fix - #1754
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve contextual declaration types for generic method values: removing the explicit function type can make the method's type arguments impossible to infer. The shared ST1023/QF1011 declaration checker now skips these values and a Go 1.27 regression covers the case.
Refs #1673.
Review update: unrelated SA9005 JSON changes and their fixture were removed through a normal follow-up commit; #1753 tracks that change independently.
Validation on the narrowed head: GOTOOLCHAIN=go1.27.0 go test ./stylecheck/st1023 passed (three tests, including the Go 1.27 fixture); git diff --check passed. QF1011 native fixture testing remains constrained by this Windows environment's missing cgo compiler.