Repository navigation
Remove brittle x/tools typeutil linknames - #1752
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Author
|
After tracing the changed helper definitions and all repository call sites at the submitted head, I found no production caller of ClassifyCall or UsedIdent; they are used only by their package tests (and a source comment refers to UsedIdent). I cannot establish a supported production input-to-error/result path or necessity for this change. Closing as necessity not established, not as no defect. This does not assess hypothetical future or external consumers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1751. Inline the helper implementations so the package no longer links against unexported x/tools symbols removed in v0.49.0. Validation: focused package tests passed with repository dependencies and with x/tools v0.49.0 through a temporary modfile.