Prefer `fmt.Errorf(...)` to `fmt.Errorf(fmt.Sprintf(...))` #1292

cdignam-segment · 2022-06-23T14:32:44Z

cdignam-segment
Jun 23, 2022

This is a style preference, but instead of writing fmt.Errorf(fmt.Sprintf("failed to connect to db: %w", err)), a developer can write fmt.Errorf("failed to connect to db: %w", err).

dominikh · 2022-06-23T14:39:34Z

dominikh
Jun 23, 2022
Maintainer

fmt.Errorf(fmt.Sprintf("failed to connect to db: %w", err)) is plain wrong and will produce incorrect results if the string returned by fmt.Sprintf contains percent signs. I'm not inclined to offer a "simplification" here when the original code is wrong. But we might consider flagging the bug.

0 replies

Navigation Menu

Repository navigation

Prefer `fmt.Errorf(...)` to `fmt.Errorf(fmt.Sprintf(...))` #1292

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Prefer fmt.Errorf(...) to fmt.Errorf(fmt.Sprintf(...)) #1292

Uh oh!

cdignam-segment Jun 23, 2022

Replies: 1 comment

Uh oh!

dominikh Jun 23, 2022 Maintainer

Prefer `fmt.Errorf(...)` to `fmt.Errorf(fmt.Sprintf(...))` #1292

cdignam-segment
Jun 23, 2022

dominikh
Jun 23, 2022
Maintainer