8000 fix: mypy action_quit async + lint clean by dominicusin · Pull Request #94 · dominicusin/package-maximizer · GitHub
[go: up one dir, main page]
Skip to content

fix: mypy action_quit async + lint clean - #94

Closed
dominicusin wants to merge 4 commits into
mainfrom
fix/0.21.0-mypy-quit-fix
Closed

fix: mypy action_quit async + lint clean#94
dominicusin wants to merge 4 commits into
mainfrom
fix/0.21.0-mypy-quit-fix

Conversation

@dominicusin
@dominicusin dominicusin commented Sep 8, 2026
Copy link
Copy Markdown
Owner

Fix

  • action_quit: changed to async def to match textual.app.App signature
  • All lint now passing (black, isort, mypy, flake8)
  • 849 tests, 85.09% coverage

@dominicusin
fix: restore parenthesized except syntax on main
06cc5d3
@dominicusin
fix: clean flake8 issues in changed files for 0.12.0 integration
ce716fc
@dominicusin
fix: replace all Python 2 except syntax across package_maximizer/
aa900e7
@dominicusin
feat/0.20.0: web API history + export endpoints
873cf2c 
- GET /api/v1/history — package manager transaction history
- POST /api/v1/export — maximize and export in json/csv/graphml
- 849 tests, 85.09% coverage
- All lint clean
@qodo-code-review
qodo-code-review Bot commented Sep 8, 2026
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai
coderabbitai Bot commented Sep 8, 2026
Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

< 8000 strong>Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 32d6afdd-d598-43af-8fe1-8506f4ec0b39

📥 Commits

Reviewing files that changed from the base of the PR and between 1aecbeb and 873cf2c.

📒 Files selected for processing (3)
  • package_maximizer/tui/app.py
  • package_maximizer/web/app.py
  • tests/test_web_api.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@read-the-docs-community
read-the-docs-community Bot commented Sep 8, 2026
Copy link
Copy Markdown

Documentation build overview

📚 package-maximizer | 🛠️ Build #34443161 | 📁 Comparing 873cf2c against latest (1aecbeb)

  🔍 Preview build  

2 files changed
± tui.html
± _modules/package_maximizer/tui/app.html

@dominicusin
dominicusin enabled auto-merge (squash) September 8, 2026 04:34
@dominicusin dominicusin closed this Sep 9, 2026
auto-merge was automatically disabled September 9, 2026 07:26

Pull request was closed

@dominicusin
dominicusin deleted the fix/0.21.0-mypy-quit-fix branch September 9, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dominicusin
0