Repository navigation
docs: add comprehensive project roadmap (phases 1-6) - #65
Merged
Merged
Conversation
- Added 23 tests for DI container - Coverage: di/container 73% → 89% - Tests: 555 → 578 passed, total 87% coverage
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoDocument six-phase roadmap and expand DI container test coverage
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1. Register wrapper remains untested
|
Comment on lines
+197
to
+198
| # register takes *args, so pass lifecycle string | ||
| ServiceLocator.container().register("singleton")(TestService) |
There was a problem hiding this comment.
1. Register wrapper remains untested 🐞 Bug ⚙ Maintainability
test_register calls Container.register directly instead of ServiceLocator.register, so it passes even though the public wrapper currently discards the decorator returned by Container.register and cannot register a class. This creates false coverage for the named API and leaves callers exposed to a NoneType call failure.
Agent Prompt
## Issue description
The new `test_register` bypasses `ServiceLocator.register`, leaving the public wrapper's broken return behavior undetected.
## Issue Context
`Container.register` returns a class decorator, but `ServiceLocator.register` currently discards that return value. Update the wrapper to return the decorator and make the test invoke the wrapper itself.
## Fix Focus Areas
- tests/test_di_container.py[190-199]
- package_maximizer/di/container.py[141-144]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+42
to
+45
| ### 1.2. Фатальный CI gate `--cov-fail-under=90` | ||
|
|
||
| **Текущее:** 85% (нефатальное) | ||
| **Цель:** 90% (фатальное) |
There was a problem hiding this comment.
2. Ci gate status is wrong 🐞 Bug ⚙ Maintainability
The roadmap labels the current 85% coverage threshold as nonfatal, but Ubuntu CI passes --cov-fail-under=85 directly to pytest and fails when coverage is below it. This incorrect baseline makes the Phase 1 work item misleading about what CI behavior still needs to change.
Agent Prompt
## Issue description
The roadmap incorrectly says the existing 85% coverage gate is nonfatal.
## Issue Context
Ubuntu CI sets `COV_FAIL_UNDER` to 85 and passes the corresponding `--cov-fail-under` option to pytest without suppressing failures. macOS and Windows already run without that gate.
## Fix Focus Areas
- PROJECT_PLAN.md[42-50]
- .github/workflows/ci.yml[122-134]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary