Repository navigation
test(di): add comprehensive test suite for Container and ServiceLocator - #64
Merged
Merged
Conversation
- Added 23 tests for DI container - Coverage: di/container 73% → 89% - Tests: 555 → 578 passed, total 87% coverage
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoExpand DI container and service locator test coverage
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. ServiceLocator test drops decorator
|
Comment on lines
+198
to
+199
| ServiceLocator.container().register("singleton")(TestService) | ||
| assert TestService in ServiceLocator.container()._singletons |
There was a problem hiding this comment.
1. Servicelocator test drops decorator 🐞 Bug ≡ Correctness
test_register calls ServiceLocator.container().register("singleton")(TestService), but
register("singleton") only returns a decorator and the test does not invoke that decorator with
TestService. Consequently TestService is absent from _singletons, causing the newly added test
suite to fail.
Agent Prompt
## Issue description
The test invokes `Container.register("singleton")` but discards its returned decorator, so `TestService` is never registered and the assertion fails.
## Issue Context
`Container.register` returns `decorator`; registration occurs only when that decorator is called with the class. `ServiceLocator.register` also discards the decorator, so using the container directly still requires applying the returned decorator.
## Fix Focus Areas
- tests/test_di_container.py[198-199]
Change the test to apply the decorator, for example `ServiceLocator.container().register("singleton")(TestService)` is currently syntactically present but must be verified against the implementation; alternatively use an explicit decorator variable and call it with `TestService`, or use `register_instance`. Ensure the final assertion observes `TestService` in the singleton registry.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan