8000 test: remove unused imports/variables; un-shadow duplicated test_export_post by devin-ai-integration[bot] · Pull Request #110 · dominicusin/package-maximizer · GitHub
[go: up one dir, main page]

Skip to content

test: remove unused imports/variables; un-shadow duplicated test_export_post - #110

Merged
dominicusin merged 3 commits into
mainfrom
devin/1791936200-tests-cleanup
Oct 18, 2026
Merged

dominicusin merged 3 commits into
mainfrom
devin/1791936200-tests-cleanup

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Summary

Test-suite hygiene from the audit; no production code changes.

  • tests/test_web_api.py defined test_export_post twice; the second definition shadowed the first, so it never ran. The second one is renamed to test_export_post_returns_selected, and both now execute (895 tests vs 894 before).
  • Removed ~60 unused imports and unused variables across 28 test modules (flake8 --select=F tests/ is now clean), including the PackageParser := __import__(...) walrus in test_parsers_extra.py, replaced by a plain import.

Checks

  • make test passes (895 passed, 2 skipped)
  • flake8 critical check passes; black/isort clean
  • docs updated if behavior changed (n/a)

Link to Devin session: https://app.devin.ai/sessions/7a195999dfd146d48fbc98f4bab6707a
Open in Devin Desktop: https://app.devin.ai/desktop/session/7a195999dfd146d48fbc98f4bab6707a?variant=devin
Requested by: @dominicusin

…rt_post

Co-Authored-By: dominicusin <dominicusin@yahoo.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai
coderabbitai Bot commented Oct 13, 2026 •
Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e34a39bf-9481-410c-958b-0dd1c3cdbc4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@read-the-docs-community
read-the-docs-community Bot commented Oct 13, 2026 •
Copy link
Copy Markdown

Documentation build overview

📚 package-maximizer | 🛠️ Build #35216690 | 📁 Comparing 2c667bd against latest (61e642a)

  🔍 Preview build  

No files changed.

…dows CI)

Co-Authored-By: dominicusin <dominicusin@yahoo.com>
@dominicusin
dominicusin enabled auto-merge (squash) October 18, 2026 00:08
@dominicusin
dominicusin merged commit 9a058f9 into main Oct 18, 2026
16 checks passed
@dominicusin
dominicusin deleted the devin/1791936200-tests-cleanup branch October 18, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0