8000 fix: close PROJECT_PLAN 1.3 known debts by devin-ai-integration[bot] · Pull Request #104 · dominicusin/package-maximizer · GitHub
[go: up one dir, main page]
Skip to content

fix: close PROJECT_PLAN 1.3 known debts - #104

Merged
dominicusin merged 3 commits into
mainfrom
devin/1791932720-known-debts
Oct 13, 2026
Merged

fix: close PROJECT_PLAN 1.3 known debts#104
dominicusin merged 3 commits into
mainfrom
devin/1791932720-known-debts

Conversation

@devin-ai-integration
@devin-ai-integration devin-ai-integration Bot commented Oct 13, 2026
Copy link
Copy Markdown
Contributor

Summary

Fixes all four items in PROJECT_PLAN.md §1.3 "Известные долги и баги". Running the new real-system tests also exposed two real bugs, fixed here too.

Version (web/app.py)

  • APP_VERSION = __version__. The web app now uses the package version, not its own stale "0.6.1" fallback.
  • The fallback versions had drifted apart: __init__.py 0.12.0, pyproject.toml setuptools_scm.fallback_version 0.8.0, CITATION.cff 0.6.1. All three are now 0.29.0, the latest tag, and tests/test_version_sync.py checks they stay equal.

TUI without textual

  • package-maximizer tui used to exit with an error when the tui extra was missing. It now prints a hint (pip install 'package-maximizer[tui]') and starts the text MaximizerShell instead. The two existing tests that expected the error exit are updated.

RealRepoIntegration on real systems

  • New tests/test_real_system.py, marked real_system (the marker is registered in pyproject.toml). It runs the APT tests when dpkg/apt-cache exist (ubuntu CI) and the Homebrew tests when brew exists (macOS CI); otherwise they are skipped.
  • Bugs these tests found:
    • APTParser._parse_dpkg_l read the dpkg -l legend and header lines (Err?=(none)/Reinst-required, Name, …) as packages. Rows are now filtered by the dpkg status column (_DPKG_STATUS_RE).
    • brew list --formula --cask uses two mutually exclusive flags and always failed. Both BrewParser._get_all_installed and RealRepoIntegration._get_installed_brew now run brew list -1 through the new BrewParser.parse_installed, which also sets status="installed". Before, the parser defaulted to candidate.

CHANGELOG

  • Removed the stale "Planned" section (JWT, Flask-Limiter) and merged the two duplicate [0.6.0] sections.
  • Added [Unreleased] with this PR's changes, plus a short summary of releases 0.11.0–0.29.0, which were tagged without CHANGELOG entries.
  • The four §1.3 items are checked off in PROJECT_PLAN.md.

Checks

  • make test passes (Linux): 859 passed, 2 skipped. The brew real-system test is skipped on Linux.
  • flake8 critical check passes; black and isort are clean
  • docs updated if behavior changed (CHANGELOG, PROJECT_PLAN)

Reviewer note: test_real_system.py runs the real dpkg -l, apt-cache show and brew list -1 on CI hosts. These commands are read-only.

Link to Devin session: https://app.devin.ai/sessions/7a195999dfd146d48fbc98f4bab6707a
Open in Devin Desktop: https://app.devin.ai/desktop/session/7a195999dfd146d48fbc98f4bab6707a?variant=devin
Requested by: @dominicusin

@devin-ai-integration @dominicusin
fix: close PROJECT_PLAN known debts
5753465 
- web: APP_VERSION from package __version__; sync fallback versions (0.29.0)
- tui: fall back to text shell when textual is missing
- apt: skip dpkg -l header rows; brew: use valid 'brew list -1'
- tests: real-system RealRepoIntegration tests, version sync test
- CHANGELOG: drop stale Planned, merge duplicate 0.6.0, add Unreleased

Co-Authored-By: dominicusin <dominicusin@yahoo.com>
@devin-ai-integration
devin-ai-integration Bot commented Oct 13, 2026
Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai
coderabbitai Bot commented Oct 13, 2026 •
edited
Loading
Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHIL 8000 L
  • Plan: Advanced
  • Run ID: 1ac031f3-1e1f-4801-9f11-7f2e09c8fd27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@read-the-docs-community
read-the-docs-community Bot commented Oct 13, 2026 •
edited
Loading
Copy link
Copy Markdown

Documentation build overview

📚 package-maximizer | 🛠️ Build #35130442 | 📁 Comparing ffcfadf against latest (5c4d3f0)

  🔍 Preview build  

3 files changed
± _modules/package_maximizer/integrations/real_repo_integration.html
± _modules/package_maximizer/tui/app.html
± _modules/package_maximizer/web/app.html

@dominicusin
dominicusin enabled auto-merge (squash) October 13, 2026 23:24
@dominicusin
dominicusin merged commit e41cce8 into main Oct 13, 2026
16 checks passed
@dominicusin
dominicusin deleted the devin/1791932720-known-debts branch October 13, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominicusin dominicusin Awaiting requested review from dominicusin dominicusin is a code owner

Assignees

@dominicusin dominicusin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dominicusin
0