8000 Name the object types in the headings of jetdb prop in words, not after the enum by dominion525 · Pull Request #190 · dominion525/jetdb · GitHub
[go: up one dir, main page]

Skip to content

Name the object types in the headings of jetdb prop in words, not after the enum - #190

Merged
dominion525 merged 1 commit into
mainfrom
fix/prop-heading-names
Oct 26, 2026
Merged

dominion525 merged 1 commit into
mainfrom
fix/prop-heading-names

Conversation

@dominion525
Copy link
Copy Markdown
Owner

Summary

  • jetdb prop headed the properties of an object with the Rust name of its ObjectType, such as LinkedTable Properties: and DatabaseProperty Properties:. It now writes words: Linked Table Properties:, Linked ODBC Table Properties:, Database Property Properties: and so on. Table Properties:, Query Properties: and Object Properties: for a type jetdb does not know stay as they are.
  • The names live in the CLI. The Display of ObjectType stays as it is, since jetdb-wasm uses it for the type names of its JavaScript API.
  • Running jetdb prop on every object of the test data before and after differs only in the 549 heading lines of linked tables and database properties. docs/cli (English and Japanese) gives examples of the headings.

🤖 Generated with Claude Code

@github-actions
github-actions Bot commented Oct 26, 2026 •
Copy link
Copy Markdown

Coverage

For 3f44e22.

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
jetdb-cli/src/export.rs            144                11    92.36%           9                 1    88.89%          72                 5    93.06%           0                 0         -
jetdb-cli/src/form.rs              248                19    92.34%          25                 5    80.00%         156                 6    96.15%           0                 0         -
jetdb-cli/src/macro_cmd.rs         120                11    90.83%           7                 2    71.43%          63                 4    93.65%           0                 0         -
jetdb-cli/src/main.rs              948                30    96.84%          83                 3    96.39%         597                21    96.48%           0                 0         -
jetdb-cli/src/prop.rs              413                21    94.92%          46                 2    95.65%         249                10    95.98%           0                 0         -
jetdb-cli/src/query.rs              64                 3    95.31%           5                 0   100.00%          32                 0   100.00%           0                 0         -
jetdb-cli/src/vba.rs                58                 3    94.83%           5                 0   100.00%          28                 0   100.00%           0                 0         -
jetdb-wasm/src/lib.rs             3919               103    97.37%         257                 4    98.44%        2066                29    98.60%           0                 0         -
jetdb/src/catalog.rs               509                14    97.25%          46                 0   100.00%         299                 3    99.00%           0                 0         -
jetdb/src/complex.rs               924                32    96.54%          73                 0   100.00%         605                15    97.52%           0                 0         -
jetdb/src/crypto.rs               2300               112    95.13%         127                10    92.13%        1315                60    95.44%           0                 0         -
jetdb/src/csv.rs                   974                13    98.67%          77                 0   100.00%         557                 3    99.46%           0                 0         -
jetdb/src/data.rs                 4798                89    98.15%         299                 3    99.00%        2701                50    98.15%           0                 0         -
jetdb/src/ddl/access.rs             70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/mod.rs              2771                 8    99.71%         208                 2    99.04%        1501                 6    99.60%           0                 0         -
jetdb/src/ddl/mysql.rs              70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/postgres.rs           71                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/sqlite.rs             69                 0   100.00%           7                 0   100.00%          48                 0   100.00%           0                 0         -
jetdb/src/encoding.rs              284                 0   100.00%          30                 0   100.00%         153                 0   100.00%           0                 0         -
jetdb/src/file.rs                 1932                64    96.69%         118                 0   100.00%         989                18    98.18%           0                 0         -
jetdb/src/form.rs                 3332               133    96.01%         248                11    95.56%        1780                50    97.19%           0                 0         -
jetdb/src/form2000.rs              934                20    97.86%          73                 1    98.63%         497                 4    99.20%           0                 0         -
jetdb/src/format.rs                616                 2    99.68%          45                 0   100.00%         388                 2    99.48%           0                 0         -
jetdb/src/lib.rs                    10                 3    70.00%           1                 0   100.00%           7                 2    71.43%           0                 0         -
jetdb/src/macro_action.rs          299                19    93.65%          27                 3    88.89%         165                24    85.45%           0                 0         -
jetdb/src/macro_def.rs            2440                88    96.39%         196                 9    95.41%        1596                36    97.74%           0                 0         -
jetdb/src/macro_text.rs            804                24    97.01%          54                 2    96.30%         451                20    95.57%           0                 0         -
jetdb/src/map.rs                   416                13    96.88%          27                 0   100.00%         221                 5    97.74%           0                 0         -
jetdb/src/money.rs                 296                 0   100.00%          28                 0   100.00%         190                 0   100.00%           0                 0         -
jetdb/src/prop.rs                 1375                18    98.69%          90                 0   100.00%         695                10    98.56%           0                 0         -
jetdb/src/query.rs                2514                62    97.53%         200                 1    99.50%        1550                18    98.84%           0                 0         -
jetdb/src/relationship.rs          249                26    89.56%          22                 0   100.00%         177                10    94.35%           0                 0         -
jetdb/src/save_as_text.rs          574                27    95.30%          52                 3    94.23%         341                27    92.08%           0                 0         -
jetdb/src/storage.rs               766                32    95.82%          57                 0   100.00%         435                 6    98.62%           0                 0         -
jetdb/src/table.rs                1679                65    96.13%         109                 2    98.17%        1017                17    98.33%           0                 0         -
jetdb/src/timestamp.rs             491                 0   100.00%          51                 0   100.00%         285                 0   100.00%           0                 0         -
jetdb/src/vba.rs                   949                57    93.99%          82                11    86.59%         540                21    96.11%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            38430              1122    97.08%        2805                75    97.33%       21904               482    97.80%           0                 0         -

…er the enum

- Write the headings with words such as Linked Table Properties: and Database Property Properties: instead of the Rust names of ObjectType
- Keep the names in the CLI, and leave the Display of ObjectType, which jetdb-wasm uses for its type names, as it is
- Test the name of each type and the headings of a linked table and a database property, and add examples to docs/cli in English and Japanese

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@dominion525
dominion525 force-pushed the fix/prop-heading-names branch from 7043f03 to 3f44e22 Compare October 26, 2026 18:19
@dominion525
dominion525 merged commit 555000c into main Oct 26, 2026
11 checks passed
@dominion525
dominion525 deleted the fix/prop-heading-names branch October 26, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0