Repository navigation
Tell users how rows reads a next passed from another table - #182
Merged
Merged
Conversation
- Say in the doc comments of RowsOptions.start and Rows.next that next belongs to the table it came from, and that passing it to another table is not detected - Say that a position past the last row gives no rows and a null next - Say the same in docs/wasm in English and Japanese Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CoverageFor 43a25ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextofrowsis a position in the table it came from. Passed asstartto another table, it is not detected, and that table is read from the same position; astartpast the last row gives no rows and a nullnext. This was checked on nwind.mdb with Orders and Customers.RowsOptions.startandRows.next, which become the TypeScript types, and docs/wasm (English and Japanese) now say so. Keepingnexta number is a decision for 0.4.0.🤖 Generated with Claude Code