8000 Keep each property of form props and prop on one line when its value has line breaks by dominion525 · Pull Request #188 · dominion525/jetdb · GitHub
[go: up one dir, main page]

Skip to content

Keep each property of form props and prop on one line when its value has line breaks - #188

Merged
dominion525 merged 1 commit into
mainfrom
fix/props-one-line-values
Oct 26, 2026
Merged

dominion525 merged 1 commit into
mainfrom
fix/props-one-line-values

Conversation

@dominion525
Copy link
Copy Markdown
Owner

Summary

  • jetdb form props printed values as they are, so a CR/LF in a value such as a Caption started a new line at column 0 and broke the one-line-per-property layout (Sports.accdb, form About).
  • Text values in form props are now quoted as jetdb prop quotes them, and both commands write a carriage return, a line feed and a tab as \r, \n and \t, and other control characters as \u{..}. Values that are not text are unchanged.
  • Over the test data, prop gives the same output as before; in form props, 23,502 text values gained quotes, and with the quotes and escapes undone the output is the same as before, byte for byte.
  • docs/cli (English and Japanese) describes how values are written, and the form props example quotes its values.

🤖 Generated with Claude Code

…has line breaks

- Quote text values in form props as prop does
- Write a carriage return, a line feed and a tab as \r, \n and \t, and other control characters as \u{..}, in both commands
- Share the quoting in one CLI function, quoted
- Test a value with line breaks, and update docs/cli in English and Japanese

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Coverage

For 8f1787a.

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
jetdb-cli/src/export.rs            127                10    92.13%           6                 0   100.00%          67                 4    94.03%           0                 0         -
jetdb-cli/src/form.rs              249                19    92.37%          25                 5    80.00%         156                 6    96.15%           0                 0         -
jetdb-cli/src/macro_cmd.rs         121                11    90.91%           7                 2    71.43%          63                 4    93.65%           0                 0         -
jetdb-cli/src/main.rs              949                30    96.84%          83                 3    96.39%         597                21    96.48%           0                 0         -
jetdb-cli/src/prop.rs              335                20    94.03%          39                 2    94.87%         198                 9    95.45%           0                 0         -
jetdb-cli/src/query.rs              65                 3    95.38%           5                 0   100.00%          32                 0   100.00%           0                 0         -
jetdb-cli/src/vba.rs                59                 3    94.92%           5                 0   100.00%          28                 0   100.00%           0                 0         -
jetdb-wasm/src/lib.rs             3917               103    97.37%         257                 4    98.44%        2064                29    98.59%           0                 0         -
jetdb/src/catalog.rs               509                14    97.25%          46                 0   100.00%         299                 3    99.00%           0                 0         -
jetdb/src/complex.rs               924                32    96.54%          73                 0   100.00%         605                15    97.52%           0                 0         -
jetdb/src/crypto.rs               2300               112    95.13%         127                10    92.13%        1315                60    95.44%           0                 0         -
jetdb/src/csv.rs                   867                24    97.23%          73                 0   100.00%         492                 6    98.78%           0                 0         -
jetdb/src/data.rs                 4753                89    98.13%         297                 3    98.99%        2680                50    98.13%           0                 0         -
jetdb/src/ddl/access.rs             70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/mod.rs              2771                 8    99.71%         208                 2    99.04%        1501                 6    99.60%           0                 0         -
jetdb/src/ddl/mysql.rs              70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/postgres.rs           71                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/sqlite.rs             69                 0   100.00%           7                 0   100.00%          48                 0   100.00%           0                 0         -
jetdb/src/encoding.rs              284                 0   100.00%          30                 0   100.00%         153                 0   100.00%           0                 0         -
jetdb/src/file.rs                 1915                65    96.61%         117                 0   100.00%         983                18    98.17%           0                 0         -
jetdb/src/form.rs                 3299               131    96.03%         247                11    95.55%        1776                50    97.18%           0                 0         -
jetdb/src/form2000.rs              934                20    97.86%          73                 1    98.63%         497                 4    99.20%           0                 0         -
jetdb/src/format.rs                616                 2    99.68%          45                 0   100.00%         388                 2    99.48%           0                 0         -
jetdb/src/lib.rs                    10                 3    70.00%           1                 0   100.00%           7                 2    71.43%           0                 0         -
jetdb/src/macro_action.rs          299                19    93.65%          27                 3    88.89%         165                24    85.45%           0                 0         -
jetdb/src/macro_def.rs            2440                88    96.39%         196                 9    95.41%        1596                36    97.74%           0                 0         -
jetdb/src/macro_text.rs            804                24    97.01%          54                 2    96.30%         451                20    95.57%           0                 0         -
jetdb/src/map.rs                   416                13    96.88%          27                 0   100.00%         221                 5    97.74%           0                 0         -
jetdb/src/money.rs                 296                 0   100.00%          28                 0   100.00%         190                 0   100.00%           0                 0         -
jetdb/src/prop.rs                 1375                18    98.69%          90                 0   100.00%         695                10    98.56%           0                 0         -
jetdb/src/query.rs                2514                62    97.53%         200                 1    99.50%        1550                18    98.84%           0                 0         -
jetdb/src/relationship.rs          249                26    89.56%          22                 0   100.00%         177                10    94.35%           0                 0         -
jetdb/src/save_as_text.rs          574                27    95.30%          52                 3    94.23%         341                27    92.08%           0                 0         -
jetdb/src/storage.rs               764                32    95.81%          57                 0   100.00%         434                 6    98.62%           0                 0         -
jetdb/src/table.rs                1679                65    96.13%         109                 2    98.17%        1017                17    98.33%           0                 0         -
jetdb/src/timestamp.rs             491                 0   100.00%          51                 0   100.00%         285                 0   100.00%           0                 0         -
jetdb/src/vba.rs                   949                57    93.99%          82                11    86.59%         540                21    96.11%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            38134              1130    97.04%        2787                74    97.34%       21749               483    97.78%           0                 0         -

@dominion525
dominion525 merged commit f6cbebd into main Oct 26, 2026
11 checks passed
@dominion525
dominion525 deleted the fix/props-one-line-values branch October 26, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0