Repository navigation
Treat jetdb without a subcommand as clap treats a missing subcommand, under the name jetdb - #168
Merged
Merged
Conversation
… under the name jetdb - Name the clap command jetdb, so the usage without a subcommand and --version say jetdb instead of jetdb-cli - Leave jetdb with no arguments to clap, which prints the usage to stderr and exits with 2 - Exit with clap's error for a missing subcommand, and 2, when options are given without a subcommand - Test no arguments, options only, --help-skill and --version Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CoverageFor 4772c4d. |
- Give clap the bin_name jetdb, since the usage without arguments took the name of the executable, jetdb.exe on Windows, and the test failed there - The usage for options without a subcommand, which already said jetdb, now agrees with it on every OS Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jetdbwithout a subcommand printed its help to stdout asUsage: jetdb-cli ...and exited with 1, andjetdb --versionprintedjetdb-cli <version>.jetdb-cli; the command is now namedjetdb. The version is unchanged.jetdbwith no arguments is left to clap (arg_required_else_help): likejetdb form, it prints the usage to stderr and exits with 2. Options without a subcommand, such as only--password, give clap's error for a missing subcommand and exit with 2.--help-skillis unchanged, and the help of every subcommand is the same as before except for the command name. New tests cover no arguments, options only,--help-skilland--version.🤖 Generated with Claude Code